[webkit-reviews] review granted: [Bug 204748] [iOS] Introduce a gesture recognizer that can be used to defer recognition of other gestures : [Attachment 384628] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 204748: [iOS] Introduce a gesture recognizer that can be used to defer
recognition of other gestures
https://bugs.webkit.org/show_bug.cgi?id=204748

Attachment 384628: Patch

https://bugs.webkit.org/attachment.cgi?id=384628&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 384628
  --> https://bugs.webkit.org/attachment.cgi?id=384628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384628&action=review

> Source/WebKit/ChangeLog:25
> +	   gesture from connecting the entire gesture subgraph under WKWebView
through failure depencies. This would result

sp depencies

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:209
> +    RetainPtr<WKDeferringGestureRecognizer>
_touchEventDeferringGestureRecognizerForImmediatelyResettableGestures;
> +    RetainPtr<WKDeferringGestureRecognizer>
_touchEventDeferringGestureRecognizerForDelayedResettableGestures;

Are these "touch-event-deferring" (that's how I read it)? Don't they defer many
things /pending/ touch event reply?

> Source/WebKit/UIProcess/ios/WKDeferringGestureRecognizer.h:36
> +- (instancetype)initWithView:(WKContentView *)view;

In an ideally-generic world this would probably be 

- (instancetype)initWithView:(UIView *)view delegate:(id
<WKDeferringGestureRecognizerDelegate>)delegate;

And not know anything about WKContentView.

Does that make it any more useful? It does seem like it could be useful outside
of WKContentView.