[webkit-reviews] review granted: [Bug 204411] [JSConly] 32-bits warning on memset of JSValue : [Attachment 384596] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Paulo Matos <pmatos at igalia.com>'s
request for review:
Bug 204411: [JSConly] 32-bits warning on memset of JSValue
https://bugs.webkit.org/show_bug.cgi?id=204411

Attachment 384596: Patch

https://bugs.webkit.org/attachment.cgi?id=384596&action=review




--- Comment #16 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384596
  --> https://bugs.webkit.org/attachment.cgi?id=384596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384596&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   Implemented alternative to memset, and refactored solutions.
> +	   Fixes warning on 32bit builds.

It's probably worth adding a comment here that a compiler may choose to
optimize away the memset (given Saam's question), or elaborate on what the
warning is if it is related.