[webkit-reviews] review granted: [Bug 204570] Simplify RealtimeOutgoingAudioSource and RealtimeOutgoingVideooSource observeSource/unobserveSource pattern : [Attachment 384298] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 204570: Simplify RealtimeOutgoingAudioSource and
RealtimeOutgoingVideooSource observeSource/unobserveSource pattern
https://bugs.webkit.org/show_bug.cgi?id=204570

Attachment 384298: Patch

https://bugs.webkit.org/attachment.cgi?id=384298&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 384298
  --> https://bugs.webkit.org/attachment.cgi?id=384298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384298&action=review

> Source/WebCore/ChangeLog:9
> +	   We made LibWebRTCRTCRtpSenderBackend ending the observing in its
destructor.

Nit: s/ending the observing/stop observing/

> Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.cpp:49
> +#ifndef NDEBUG

"#if !ASSERT_DISABLED" might be better here.

> Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:60
> +#ifndef NDEBUG

Ditto.