[webkit-reviews] review granted: [Bug 204726] [32-bits] Check if StructureStubInfo::patch.baseTagGPR is used somewhere. : [Attachment 384577] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 204726: [32-bits] Check if StructureStubInfo::patch.baseTagGPR is used
somewhere.
https://bugs.webkit.org/show_bug.cgi?id=204726

Attachment 384577: Patch

https://bugs.webkit.org/attachment.cgi?id=384577&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384577
  --> https://bugs.webkit.org/attachment.cgi?id=384577
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384577&action=review

r=me with ChangeLog fix.

> Source/JavaScriptCore/ChangeLog:10
> +	    When we generate ByIdInlineCache and ByValInlineCache, `base` is
always
> +	    a cell. Given that, we don't need to store `baseTag` on 32-bits
> +	    version. This patch is removing
StructureStubInfo::patch.baseTagGPR.

Please fix the alignment.  These lines appear to be off by one (they have 1
extra space).

Please add a comment here that the code also doesn't make use of the
patch.baseTagGPR.  It's being passed around, and the register is allocated, but
no instructions are being emitted that uses it.