[webkit-reviews] review granted: [Bug 204721] Disable LocalCurrentGraphicsContext when doing DisplayList recording : [Attachment 384549] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 1 08:40:17 PST 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 204721: Disable LocalCurrentGraphicsContext when doing DisplayList
recording
https://bugs.webkit.org/show_bug.cgi?id=204721

Attachment 384549: Patch

https://bugs.webkit.org/attachment.cgi?id=384549&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 384549
  --> https://bugs.webkit.org/attachment.cgi?id=384549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384549&action=review

>> Source/WebCore/platform/mac/LocalCurrentGraphicsContext.mm:36
>> +	    m_savedNSGraphicsContext = 0;
> 
> Uh... don't know why 0, I just copied from below. I'll make it `nil`.

Should probably WTFLogAlways() or LOG(DisplayLists, ) here to tell us we've
done something wrong.


More information about the webkit-reviews mailing list