[webkit-reviews] review granted: [Bug 200082] [iOS] Add a test to ensure that a tap in editable content shows the callout bar if the selection did not change : [Attachment 377711] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 200082: [iOS] Add a test to ensure that a tap in editable content shows the
callout bar if the selection did not change
https://bugs.webkit.org/show_bug.cgi?id=200082

Attachment 377711: Patch

https://bugs.webkit.org/attachment.cgi?id=377711&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 377711
  --> https://bugs.webkit.org/attachment.cgi?id=377711
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
> +    input = document.querySelector("input");

Dodgy way to declare a global :)

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
> +    await UIHelper.callFunctionAndWaitForEvent(() =>
UIHelper.chooseMenuAction("Select All"), document, "selectionchange");

I find it easier to parse if the arrow function has {}, but up to you.