[webkit-reviews] review granted: [Bug 201242] Fix interpretation of fraction shifts : [Attachment 377765] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rbuis at igalia.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 201242: Fix interpretation of fraction shifts
https://bugs.webkit.org/show_bug.cgi?id=201242

Attachment 377765: Patch

https://bugs.webkit.org/attachment.cgi?id=377765&action=review




--- Comment #12 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 377765
  --> https://bugs.webkit.org/attachment.cgi?id=377765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377765&action=review

LGTM.

> LayoutTests/ChangeLog:3
> +	   Bug 201242 - Fix interpretation of fraction shifts

No need for Bug * part.

> LayoutTests/imported/w3c/ChangeLog:3
> +	   Bug 201242 - Fix interpretation of fraction shifts

Ditto.

> Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:93
> +    // See
https://mathml-refresh.github.io/mathml-core/#fraction-with-nonzero-line-thickn
ess

I think comments end with period, period.

> Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:131
> +    // See
https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness

Ditto.