[webkit-reviews] review granted: [Bug 201364] DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID : [Attachment 377764] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 30 16:47:02 PDT 2019


John Wilander <wilander at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 201364: DocumentStorageAccess::hasStorageAccess() / requestStorageAccess()
don't need to know about pageID / frameID
https://bugs.webkit.org/show_bug.cgi?id=201364

Attachment 377764: Patch

https://bugs.webkit.org/attachment.cgi?id=377764&action=review




--- Comment #2 from John Wilander <wilander at apple.com> ---
Comment on attachment 377764
  --> https://bugs.webkit.org/attachment.cgi?id=377764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377764&action=review

LGTM. See nit.

> Source/WebCore/page/ChromeClient.h:-491
> -    virtual void requestStorageAccess(RegistrableDomain&&
/*subFrameDomain*/, RegistrableDomain&& /*topFrameDomain*/, FrameIdentifier,
PageIdentifier, WTF::CompletionHandler<void(StorageAccessWasGranted,
StorageAccessPromptWasShown)>&& completionHandler) {
completionHandler(StorageAccessWasGranted::No,
StorageAccessPromptWasShown::No); }

Now you can remove #include "FrameIdentifier.h"


More information about the webkit-reviews mailing list