[webkit-reviews] review granted: [Bug 201355] [LFC] Pass FormattingContext to Geometry/Quirks/BlockMarginCollapsing classes : [Attachment 377749] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 201355: [LFC] Pass FormattingContext to
Geometry/Quirks/BlockMarginCollapsing classes
https://bugs.webkit.org/show_bug.cgi?id=201355

Attachment 377749: Patch

https://bugs.webkit.org/attachment.cgi?id=377749&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 377749
  --> https://bugs.webkit.org/attachment.cgi?id=377749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377749&action=review

> Source/WebCore/layout/FormattingContextQuirks.cpp:56
> +	       auto verticalMargin =
Geometry(formattingContext()).computedVerticalMargin(*containingBlock,
usedValues);

You could do

formattingContext().geometry().computedVerticalMargin()

here and elsewhere