[webkit-reviews] review granted: [Bug 201345] Fix a bug SlotVisitor::reportZappedCellAndCrash() and also capture more information. : [Attachment 377747] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 201345: Fix a bug SlotVisitor::reportZappedCellAndCrash() and also capture
more information.
https://bugs.webkit.org/show_bug.cgi?id=201345

Attachment 377747: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=377747&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 377747
  --> https://bugs.webkit.org/attachment.cgi?id=377747
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=377747&action=review

r=me

> Source/JavaScriptCore/heap/SlotVisitor.cpp:-829
> -    uint32_t* cellWords = reinterpret_cast_ptr<uint32_t*>(this);

Fun!

> Source/JavaScriptCore/heap/SlotVisitor.cpp:835
> +    uint64_t headerWord = cellWords[0];
> +    uint64_t zapReasonAndMore = cellWords[1];

Looks nice extension. At least, we can access 16bytes :)