[webkit-reviews] review granted: [Bug 201302] Abstract out LibWebRTCSocketClient so that rtc sockets can be implemented without libwebrtc sockets : [Attachment 377585] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 201302: Abstract out LibWebRTCSocketClient so that rtc sockets can be
implemented without libwebrtc sockets
https://bugs.webkit.org/show_bug.cgi?id=201302

Attachment 377585: Patch

https://bugs.webkit.org/attachment.cgi?id=377585&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377585
  --> https://bugs.webkit.org/attachment.cgi?id=377585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377585&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166
> +std::unique_ptr<NetworkRTCProvider::Socket>
NetworkRTCProvider::takeSocket(uint64_t identifier)

A trailing return type here would remove the need for an extra
NetworkRTCProvider::

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:74
> +	   enum class Type { UDP, ServerTCP, ClientTCP, ServerConnectionTCP };

What's the difference between "ServerTCP" and "ServerConnectionTCP"?  Should
"ServerTCP" be "ServerListeningTCP"?
Also, these can all fit in a uint8_t.