[webkit-reviews] review granted: [Bug 201100] results.webkit.org: Add endpoints to upload and download archives : [Attachment 377723] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 201100: results.webkit.org: Add endpoints to upload and download archives
https://bugs.webkit.org/show_bug.cgi?id=201100

Attachment 377723: Patch

https://bugs.webkit.org/attachment.cgi?id=377723&action=review




--- Comment #16 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 377723
  --> https://bugs.webkit.org/attachment.cgi?id=377723
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377723&action=review

> Tools/resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py:108
> +    def test_invalid_metadata(self, client, **kwargs):

Would be nice to have unit-tests to cover all the error messages, like 'No
archive provided', 'Expected meta-data to be json', 'Expected commit meta-data
to be json', 'Invalid configuration, error:', 'No archives matching the
specified criteria'.