[webkit-reviews] review granted: [Bug 201157] [FTW] Use DirectX SharedResource as basis for SharedBitmap : [Attachment 377681] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 201157: [FTW] Use DirectX SharedResource as basis for SharedBitmap
https://bugs.webkit.org/show_bug.cgi?id=201157

Attachment 377681: Patch

https://bugs.webkit.org/attachment.cgi?id=377681&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377681
  --> https://bugs.webkit.org/attachment.cgi?id=377681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377681&action=review

> Source/WebKit/Platform/SharedMemory.h:83
> +	   static bool decodeHandle(IPC::Decoder&, HANDLE&);

Could you make this return Optional<HANDLE>?

> Source/WebKit/Shared/win/ShareableBitmapDirect2D.cpp:60
> +bool
ShareableBitmap::Configuration::decodeSharedResourceHandle(IPC::Decoder&
decoder)

These wrappers seem a bit excessive.  This code looks like it just belongs in
the call site.