[webkit-reviews] review requested: [Bug 201339] [EME] Introduce a Proxy CDM for thread-safe access to CDM instances from background decryption threads : [Attachment 377700] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 30 05:20:50 PDT 2019
Charlie Turner <cturner at igalia.com> has asked for review:
Bug 201339: [EME] Introduce a Proxy CDM for thread-safe access to CDM instances
from background decryption threads
https://bugs.webkit.org/show_bug.cgi?id=201339
Attachment 377700: Patch
https://bugs.webkit.org/attachment.cgi?id=377700&action=review
--- Comment #1 from Charlie Turner <cturner at igalia.com> ---
Created attachment 377700
--> https://bugs.webkit.org/attachment.cgi?id=377700&action=review
Patch
This won't build on Mac ports because I haven't modifieded the CDM instance
there. Review on the approach is appreciated, the ClearKey proxy CDM in the
future should contain all the GCrypt code in my opinion, right now it wastes a
lot of copies shoving all the keys into the background decryptor threads
More information about the webkit-reviews
mailing list