[webkit-reviews] review granted: [Bug 132869] [Texmap][GStreamer] Add support to upload more color formats into the texture : [Attachment 377333] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Chris Lord
<clord at igalia.com>'s request for review:
Bug 132869: [Texmap][GStreamer] Add support to upload more color formats into
the texture
https://bugs.webkit.org/show_bug.cgi?id=132869

Attachment 377333: Patch

https://bugs.webkit.org/attachment.cgi?id=377333&action=review




--- Comment #20 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 377333
  --> https://bugs.webkit.org/attachment.cgi?id=377333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377333&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
191
> +    bool hasMappedTextures() const { return m_hasMappedTextures; }

doesHaveMappedTextures, same for the attribute.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:571
> +    std::vector<std::pair<GLuint, GLuint> > texturesAndSamplers = {
> +	   { textures[0], program->samplerYLocation() },
> +	   { textures[1], program->samplerULocation() },
> +	   { textures[2], program->samplerVLocation() }
> +    };

5 lines too much, 2 likes ok, I guess 1 line two long

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:620
> +    std::vector<std::pair<GLuint, GLuint> > texturesAndSamplers = {
> +	   { textures[0], program->samplerYLocation() },
> +	   { textures[1], program->samplerULocation() }
> +    };

2 lines?

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:34
> +#include <vector>

I'd rather use wtf/Vector instead.