[webkit-reviews] review requested: [Bug 201324] Remove StorageArea pointers in StorageManagerSet when removing StorageManagers that own them : [Attachment 377666] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has asked  for review:
Bug 201324: Remove StorageArea pointers in StorageManagerSet when removing
StorageManagers that own them
https://bugs.webkit.org/show_bug.cgi?id=201324

Attachment 377666: Patch

https://bugs.webkit.org/attachment.cgi?id=377666&action=review




--- Comment #1 from Alex Christensen <achristensen at apple.com> ---
Created attachment 377666

  --> https://bugs.webkit.org/attachment.cgi?id=377666&action=review

Patch

This prevents crashes that look like this:

Thread 7 Crashed:: Dispatch queue: com.apple.WebKit.WebStorage
0   com.apple.WebKit			0x0000000101cd72e8
WTF::HashTableConstIterator<WTF::ObjectIdentifier<IPC::Connection::UniqueIDType
>, WTF::ObjectIdentifier<IPC::Connection::UniqueIDType>,
WTF::IdentityExtractor,
WTF::ObjectIdentifierHash<IPC::Connection::UniqueIDType>,
WTF::HashTraits<WTF::ObjectIdentifier<IPC::Connection::UniqueIDType> >,
WTF::HashTraits<WTF::ObjectIdentifier<IPC::Connection::UniqueIDType> > >
WTF::HashTable<WTF::ObjectIdentifier<IPC::Connection::UniqueIDType>,
WTF::ObjectIdentifier<IPC::Connection::UniqueIDType>, WTF::IdentityExtractor,
WTF::ObjectIdentifierHash<IPC::Connection::UniqueIDType>,
WTF::HashTraits<WTF::ObjectIdentifier<IPC::Connection::UniqueIDType> >,
WTF::HashTraits<WTF::ObjectIdentifier<IPC::Connection::UniqueIDType> >
>::find<WTF::IdentityHashTranslator<WTF::HashTraits<WTF::ObjectIdentifier<IPC::
Connection::UniqueIDType> >,
WTF::ObjectIdentifierHash<IPC::Connection::UniqueIDType> >,
WTF::ObjectIdentifier<IPC::Connection::UniqueIDType>
>(WTF::ObjectIdentifier<IPC::Connection::UniqueIDType> const&) const + 106
(ObjectIdentifier.h:77)
1   com.apple.WebKit			0x0000000101cc9308
WebKit::StorageArea::removeListener(WTF::ObjectIdentifier<IPC::Connection::Uniq
ueIDType>) + 36 (HashTable.h:383)
2   com.apple.WebKit			0x0000000101cd8e28
WTF::Detail::CallableWrapper<WebKit::StorageManagerSet::removeConnection(IPC::C
onnection&)::$_8, void>::call() + 106 (HashTable.h:183)
3   libdispatch.dylib			0x00007fff70501553
_dispatch_call_block_and_release + 12
4   libdispatch.dylib			0x00007fff705024de
_dispatch_client_callout + 8
5   libdispatch.dylib			0x00007fff70507a9e
_dispatch_lane_serial_drain + 597
6   libdispatch.dylib			0x00007fff70508422
_dispatch_lane_invoke + 363
7   libdispatch.dylib			0x00007fff70511aa1
_dispatch_workloop_worker_thread + 598
8   libsystem_pthread.dylib		0x00007fff7075b763 _pthread_wqthread +
290
9   libsystem_pthread.dylib		0x00007fff7075b5bf start_wqthread + 15