[webkit-reviews] review denied: [Bug 201312] Disable CFNetwork AppSSO interception for WebKitLegacy : [Attachment 377624] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 201312: Disable CFNetwork AppSSO interception for WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=201312

Attachment 377624: Patch

https://bugs.webkit.org/attachment.cgi?id=377624&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 377624
  --> https://bugs.webkit.org/attachment.cgi?id=377624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377624&action=review

> Source/WebKitLegacy/mac/ChangeLog:5
> +	   Disable CFNetwork AppSSO interception for WebKitLegacy
> +	   https://bugs.webkit.org/show_bug.cgi?id=201312
> +	   <rdar://problem/54853399>

Please include an explanation of why this change is being made in the
ChangeLog.

> Source/WebKitLegacy/mac/WebView/WebView.mm:1592
> +#if HAVE(APP_SSO)
> +    [NSURLSession _disableAppSSO];
> +#endif

What is the effect outside of WebKit of doing this? From the name, it doesn't
seem like this would only effect url sessions that WebKit creates, which seems
like it could be a problem.