[webkit-reviews] review granted: [Bug 201313] Wasm should tell you what function the Air/B3 code it is showing you is associated with : [Attachment 377631] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 201313: Wasm should tell you what function the Air/B3 code it is showing
you is associated with
https://bugs.webkit.org/show_bug.cgi?id=201313

Attachment 377631: Patch

https://bugs.webkit.org/attachment.cgi?id=377631&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 377631
  --> https://bugs.webkit.org/attachment.cgi?id=377631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377631&action=review

r=me with fix.

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:2267
> +	       dataLogLn("Generated B3 code for: ",
makeString(IndexOrName(functionIndex, info.nameSection->get(functionIndex))));

I think `IndexOrName` and nameSection->get's parameter is
`functionIndexInSpace` instead of `functionIndex` (functionIndexInSpace is
functionIndex + moduleInformation->importFunctionCount()). Can you check it?

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:1804
> +	   dataLogLn("Generated B3 code for: ",
makeString(IndexOrName(functionIndex, info.nameSection->get(functionIndex))));

Ditto.