[webkit-reviews] review granted: [Bug 201243] HTMLImageElement::decode() should return a resolved promise for decoding non bitmap images : [Attachment 377603] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 201243: HTMLImageElement::decode() should return a resolved promise for
decoding non bitmap images
https://bugs.webkit.org/show_bug.cgi?id=201243

Attachment 377603: Patch

https://bugs.webkit.org/attachment.cgi?id=377603&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 377603
  --> https://bugs.webkit.org/attachment.cgi?id=377603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377603&action=review

> Source/WebCore/loader/ImageLoader.cpp:388
>      m_decodingPromises.append(WTFMove(promise));

I would move this line just before "if (m_imageComplete)"

> Source/WebCore/loader/ImageLoader.cpp:391
> +	   rejectDecodePromises(WTFMove(m_decodingPromises), "Inactive
document.");

I would write promise->reject(Exception { EncodingError, "Inactive document."_s
});

> Source/WebCore/loader/ImageLoader.cpp:397
> +	   rejectDecodePromises(WTFMove(m_decodingPromises), "Missing source
URL.");

I would write promise->reject(Exception { EncodingError, "Missing source
URL."_s });

> Source/WebCore/loader/ImageLoader.cpp:405
> +void ImageLoader::resolveDecodePromises(DecodingPromises&& promises)

Can be a free function:
static inline resolveDecodePromises(DecodingPromises&& promises);

> Source/WebCore/loader/ImageLoader.cpp:412
> +void ImageLoader::rejectDecodePromises(DecodingPromises&& promises, const
char* message)

Can be a free function:
static inline rejectDecodePromises(Vector<RefPtr<DeferredPromise>>&& promises);

> Source/WebCore/loader/ImageLoader.h:97
> +    using DecodingPromises = Vector<RefPtr<DeferredPromise>, 1>;

Do we really need 1?
Can we just use a regular Vector?

> Source/WebCore/loader/ImageLoader.h:100
> +    static void rejectDecodePromises(DecodingPromises&&, const char*
message);

Please make these free functions.