[webkit-reviews] review granted: [Bug 201177] Use WebPageProxy callbacks in case of authentication challenge received from Service Worker : [Attachment 377338] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 29 07:28:54 PDT 2019
Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 201177: Use WebPageProxy callbacks in case of authentication challenge
received from Service Worker
https://bugs.webkit.org/show_bug.cgi?id=201177
Attachment 377338: Patch
https://bugs.webkit.org/attachment.cgi?id=377338&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377338
--> https://bugs.webkit.org/attachment.cgi?id=377338
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=377338&action=review
> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:325
> +
store->client().didReceiveAuthenticationChallenge(WTFMove(authenticationChallen
ge));
I think we could remove this now. Is it still important to allow invalid TLS
certs if there's no visible web page with the same origin? I think we could
just add a requirement that if you want to use untrusted certs you have to have
an open view.
More information about the webkit-reviews
mailing list