[webkit-reviews] review granted: [Bug 174030] document.fonts.ready is resolved too quickly : [Attachment 376700] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174030: document.fonts.ready is resolved too quickly
https://bugs.webkit.org/show_bug.cgi?id=174030

Attachment 376700: Patch

https://bugs.webkit.org/attachment.cgi?id=376700&action=review




--- Comment #27 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 376700
  --> https://bugs.webkit.org/attachment.cgi?id=376700
Patch

The name FontFaceSet::firstLayoutDone() was a bit confusing since it is
actually a callback after the first layout, while
FrameLoaderStateMachine::firstLayoutDone() has the same name but is actually a
getter to check whether the first layout is done.

Not sure I have a better suggestion though. Maybe rename one of them e.g.
FrameLoaderStateMachine::isFirstLayoutDone() or FontFaceSet::didFirstLayout()?

In any case, LGTM thanks for working on this!