[webkit-reviews] review granted: [Bug 201123] EXIF orientation should be respected when rendering images : [Attachment 377502] Patch

Wed Aug 28 17:55:58 PDT 2019

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 201123: EXIF orientation should be respected when rendering images
https://bugs.webkit.org/show_bug.cgi?id=201123

Attachment 377502: Patch

https://bugs.webkit.org/attachment.cgi?id=377502&action=review

--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 377502
  --> https://bugs.webkit.org/attachment.cgi?id=377502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377502&action=review

> LayoutTests/fast/images/exif-orientation-composited.html:-3
> -<html>
> -<head>
> -<script>

This is an important test to keep. It tests the directly-composited image code
path (see RenderLayerBacking::isDirectlyCompositedImage()).