[webkit-reviews] review granted: [Bug 201006] Wasm's AirIRGenerator::addLocal() and B3IRGenerator::addLocal() are doing unnecessary overflow checks. : [Attachment 377483] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 28 14:18:11 PDT 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 201006: Wasm's AirIRGenerator::addLocal() and B3IRGenerator::addLocal() are
doing unnecessary overflow checks.
https://bugs.webkit.org/show_bug.cgi?id=201006

Attachment 377483: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=377483&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 377483
  --> https://bugs.webkit.org/attachment.cgi?id=377483
proposed patch.

r=me. These checks are redundant to WasmFunctionParser and the responsibility
of this check should belong to WasmFunctionParser. Not to each client.


More information about the webkit-reviews mailing list