[webkit-reviews] review granted: [Bug 201174] Skip fetch event dispatching if no fetch event handler is added at script evaluation time : [Attachment 377326] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 201174: Skip fetch event dispatching if no fetch event handler is added at
script evaluation time
https://bugs.webkit.org/show_bug.cgi?id=201174

Attachment 377326: Patch

https://bugs.webkit.org/attachment.cgi?id=377326&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 377326
  --> https://bugs.webkit.org/attachment.cgi?id=377326
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377326&action=review

> Source/WebCore/workers/service/server/SWServerWorker.h:115
> +    bool shouldSkipFetchEvent() const { return m_shouldSkipHandleFetch &&
*m_shouldSkipHandleFetch; }

return m_shouldSkipHandleFetch.valueOr(false); would look nicer IMO.

> Source/WebCore/workers/service/server/SWServerWorker.h:135
> +    Optional<bool> m_shouldSkipHandleFetch;

Do we really need an Optional<> ? Why cannot it be a bool that is
default-initialized to false? Nobody seems to rely on it being nullopt at the
moment.