[webkit-reviews] review granted: [Bug 199606] Make tabIndex IDL attribute reflect its content attribute : [Attachment 377071] Fix svg/custom/tabindex-order.html on Windows

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 199606: Make tabIndex IDL attribute reflect its content attribute
https://bugs.webkit.org/show_bug.cgi?id=199606

Attachment 377071: Fix svg/custom/tabindex-order.html on Windows

https://bugs.webkit.org/attachment.cgi?id=377071&action=review




--- Comment #23 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 377071
  --> https://bugs.webkit.org/attachment.cgi?id=377071
Fix svg/custom/tabindex-order.html on Windows

View in context: https://bugs.webkit.org/attachment.cgi?id=377071&action=review

r=me with nit.

> Source/WebCore/dom/Element.cpp:270
> +    auto tabIndex = tabIndexSetExplicitly();

nit: Could be:
return tabIndexSetExplicitly().valueOr(defaultTabIndex());