[webkit-reviews] review granted: [Bug 201189] results.webkit.org: Sanitize all commit arguments on upload : [Attachment 377397] Patch

Tue Aug 27 16:40:40 PDT 2019

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 201189: results.webkit.org: Sanitize all commit arguments on upload
https://bugs.webkit.org/show_bug.cgi?id=201189

Attachment 377397: Patch

https://bugs.webkit.org/attachment.cgi?id=377397&action=review

--- Comment #9 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 377397
  --> https://bugs.webkit.org/attachment.cgi?id=377397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377397&action=review

> Tools/resultsdbpy/resultsdbpy/controller/commit_unittest.py:102
> +    def assertRaisesWithMessage(self, msg, func, *args, **kwargs):

is this used anywhere?

> Tools/resultsdbpy/resultsdbpy/controller/commit_unittest.py:140
> +	   self.assertEqual(str(error.exception), "'<html>1234</html>' is an
invalid commit id")

Please add a test-case for checking the max length as well.