[webkit-reviews] review granted: [Bug 201202] Update PACCage changes for builds without Giga Cage, but with signed pointers : [Attachment 377383] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 27 15:06:30 PDT 2019


Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 201202: Update PACCage changes for builds without Giga Cage, but with
signed pointers
https://bugs.webkit.org/show_bug.cgi?id=201202

Attachment 377383: Patch

https://bugs.webkit.org/attachment.cgi?id=377383&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 377383
  --> https://bugs.webkit.org/attachment.cgi?id=377383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377383&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   Update PACCage changes for builds without Giga Cage, but with signed
pointers

"Giga Cage" => "Gigacage"

> Source/JavaScriptCore/ChangeLog:8
> +	   Factored out the untaging of pointers and added that to both the
Giga Cage enabled

"Giga Cage" => "Gigacage"
"untaging" -> "untagging"


More information about the webkit-reviews mailing list