[webkit-reviews] review granted: [Bug 201191] Fix applying diffs that only change file mode : [Attachment 377356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 27 13:03:19 PDT 2019


Daniel Bates <dbates at webkit.org> has granted James Darpinian
<jdarpinian at gmail.com>'s request for review:
Bug 201191: Fix applying diffs that only change file mode
https://bugs.webkit.org/show_bug.cgi?id=201191

Attachment 377356: Patch

https://bugs.webkit.org/attachment.cgi?id=377356&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 377356
  --> https://bugs.webkit.org/attachment.cgi?id=377356
Patch

I can't remember if we have tests for svn-apply the actually driver program.
Can you please check if we do in Tools/Scripts/webkitperl? If we do then please
write a test. Otherwise, this change is fine as-is since we tend not to test
the driver code - we test the library code.


More information about the webkit-reviews mailing list