[webkit-reviews] review granted: [Bug 201170] [WebCore] DataCue should not use gcProtect / gcUnprotect : [Attachment 377319] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 26 23:33:13 PDT 2019


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 201170: [WebCore] DataCue should not use gcProtect / gcUnprotect
https://bugs.webkit.org/show_bug.cgi?id=201170

Attachment 377319: Patch

https://bugs.webkit.org/attachment.cgi?id=377319&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 377319
  --> https://bugs.webkit.org/attachment.cgi?id=377319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377319&action=review

r=me

> Source/WebCore/ChangeLog:17
> +	   As a first step, this patch just converts raw JSValue +
gcProtect/gcUnprotect with JSC::Strong<>.

I suggest /converts/replaces/.


More information about the webkit-reviews mailing list