[webkit-reviews] review granted: [Bug 201101] Removing fullscreen element in rAF() callback after requestFullscreen() can leave fullscreen in inconsistent state. : [Attachment 377251] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 201101: Removing fullscreen element in rAF() callback after
requestFullscreen() can leave fullscreen in inconsistent state.
https://bugs.webkit.org/show_bug.cgi?id=201101

Attachment 377251: Patch

https://bugs.webkit.org/attachment.cgi?id=377251&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 377251
  --> https://bugs.webkit.org/attachment.cgi?id=377251
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377251&action=review

> Source/WebCore/dom/FullscreenManager.cpp:245
> +	   if (m_pendingFullscreenElement)

Nit: this test is unnecessary

> Source/WebCore/dom/FullscreenManager.cpp:271
> +	   if (m_pendingFullscreenElement)

Ditto

> LayoutTests/fullscreen/full-screen-request-removed-with-raf.html:9
> +	       if (document.webkitCurrentFullScreenElement &&
document.webkitCurrentFullScreenElement.ownerDocument)

Shouldn’t this be “! document.webkitCurrentFullScreenElement.ownerDocument”?