[webkit-reviews] review granted: [Bug 201147] Remove UIHelper.activateElementAtHumanSpeed : [Attachment 377285] Keep tests working on iOS 12

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 201147: Remove UIHelper.activateElementAtHumanSpeed
https://bugs.webkit.org/show_bug.cgi?id=201147

Attachment 377285: Keep tests working on iOS 12

https://bugs.webkit.org/attachment.cgi?id=377285&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 377285
  --> https://bugs.webkit.org/attachment.cgi?id=377285
Keep tests working on iOS 12

View in context: https://bugs.webkit.org/attachment.cgi?id=377285&action=review

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:1178
> +    dispatch_after(dispatch_time(DISPATCH_TIME_NOW,
(int64_t)(maximumIntervalBetweenSuccessiveTaps * NSEC_PER_SEC)),
dispatch_get_main_queue(), ^{

Is precisely-the-time-interval enough? do you want to wait a bit longer? or
double it or something?

>
LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation-expe
cted.txt:-11
> -CONSOLE MESSAGE: line 182: addestination can not be the same site as the
current website.

ugh