[webkit-reviews] review granted: [Bug 201145] Resync web-platform-tests/html/browsers/the-window-object from upstream : [Attachment 377262] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 26 13:27:11 PDT 2019


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 201145: Resync web-platform-tests/html/browsers/the-window-object from
upstream
https://bugs.webkit.org/show_bug.cgi?id=201145

Attachment 377262: Patch

https://bugs.webkit.org/attachment.cgi?id=377262&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 377262
  --> https://bugs.webkit.org/attachment.cgi?id=377262
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377262&action=review

>
LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/noo
pener-noreferrer-BarProp.window-expected.txt:4
> +FAIL window.open() with noreferrer should have all bars visible Can't find
variable: BroadcastChannel

Should we skip it since we do not support BroadcastChannel or is the first PASS
useful?
Should we rewrite the tests without BroadcastChannel?

>
LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/noo
pener-noreferrer-sizing.window-expected.txt:3
> +FAIL window.open() with noreferrer should have equal viewport width and
height Can't find variable: BroadcastChannel

Ditto.


More information about the webkit-reviews mailing list