[webkit-reviews] review granted: [Bug 200717] W3C test importer should be able to handle expected references with an absolute path. : [Attachment 377253] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 200717: W3C test importer should be able to handle expected references with
an absolute path.
https://bugs.webkit.org/show_bug.cgi?id=200717

Attachment 377253: Patch

https://bugs.webkit.org/attachment.cgi?id=377253&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 377253
  --> https://bugs.webkit.org/attachment.cgi?id=377253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377253&action=review

> Tools/Scripts/webkitpy/w3c/test_importer.py:313
> +		   test_parser = TestParser(vars(self.options),
filename=fullpath, host=self.host,
source_root_directory=self._source_root_directory_for_file(fullpath))

Do we need to compute the root directory for every path?
Is source_root_directory equal to the directory path given to
find_importable_tests?

> Tools/Scripts/webkitpy/w3c/test_parser.py:95
> +		   if not self.filesystem.exists(ref_file) and
href_match_file.startswith('/'):

The self.filesystem.exists(ref_file) check is probably not needed.
We probably want the href value to be whitespace-trimmed, is it the case?
Maybe we should add a test case where href="	 /test"?