[webkit-reviews] review granted: [Bug 201122] [FTW] Go back to ID2D1Bitmap as our NativeImage type : [Attachment 377218] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 201122: [FTW] Go back to ID2D1Bitmap as our NativeImage type
https://bugs.webkit.org/show_bug.cgi?id=201122

Attachment 377218: Patch

https://bugs.webkit.org/attachment.cgi?id=377218&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377218
  --> https://bugs.webkit.org/attachment.cgi?id=377218
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377218&action=review

> Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp:166
> +    ASSERT_NOT_IMPLEMENTED_YET();

This is a poorly named macro.

> Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:837
> +    COMPtr<ID2D1Bitmap> tileImage = sourceImage;

What if we passed a ComPtr&& as a parameter instead of a raw pointer?

> Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp:49
> +void swizzleAndPremultiply(const uint8_t* srcRows, unsigned rowCount,
unsigned colCount, unsigned srcStride, unsigned destStride, uint8_t* destRows)

Is this a hot path?  It might benefit from some manual SIMD with intrinsics
someday.

> Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp:140
> +void inPlaceSwizzle(uint8_t* byteData, unsigned byteCount)

ditto

> Source/WebCore/svg/graphics/SVGImage.cpp:257
> +#ifndef _NDEBUG

#if !ASSERT_DISABLED