[webkit-reviews] review granted: [Bug 200900] Selectively enable extensions in ANGLE backend for WebGL : [Attachment 377156] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Austin Eng
<enga at chromium.org>'s request for review:
Bug 200900: Selectively enable extensions in ANGLE backend for WebGL
https://bugs.webkit.org/show_bug.cgi?id=200900

Attachment 377156: Patch

https://bugs.webkit.org/attachment.cgi?id=377156&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377156
  --> https://bugs.webkit.org/attachment.cgi?id=377156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377156&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:360
> +    size_t requiredExtensionCount = sizeof(requiredExtensions) /
sizeof(requiredExtensions[0]);

We usually use WTF_ARRAY_LENGTH for things like this.

> Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:361
> +    for (unsigned i = 0; i < requiredExtensionCount; ++i) {

Nit: Why not use unsigned for both or size_t for both?

> Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:371
> +    size_t optionalExtensionCount = sizeof(optionalExtensions) /
sizeof(optionalExtensions[0]);
> +    for (unsigned i = 0; i < optionalExtensionCount; ++i) {

ditto