[webkit-reviews] review granted: [Bug 201074] CacheStorageConnection::computeRealBodySize is not thread-safe : [Attachment 377236] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 201074: CacheStorageConnection::computeRealBodySize is not thread-safe
https://bugs.webkit.org/show_bug.cgi?id=201074

Attachment 377236: Patch

https://bugs.webkit.org/attachment.cgi?id=377236&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 377236
  --> https://bugs.webkit.org/attachment.cgi?id=377236
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377236&action=review

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:38
> +    if (isMainThread())

This branch is not really needed, callOnMainThreadAndWait() already does the
right thing for you. Or are you doing this as an optimization to avoid the
isolatedCopy() of the FormData? I guess that's fine.