[webkit-reviews] review granted: [Bug 194367] Missing media controls when WebKit is built with Python3 : [Attachment 377080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 26 02:05:36 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 194367: Missing media controls when WebKit is built with Python3
https://bugs.webkit.org/show_bug.cgi?id=194367

Attachment 377080: Patch

https://bugs.webkit.org/attachment.cgi?id=377080&action=review




--- Comment #58 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 377080
  --> https://bugs.webkit.org/attachment.cgi?id=377080
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377080&action=review

> Source/JavaScriptCore/Scripts/jsmin.py:94
> +		   raise ValueError("ERROR: The script jsmin.py only can handle
text input, but it received input with type %s" % type(char))

I think it should be "can only handle" and "received input of type"


More information about the webkit-reviews mailing list