[webkit-reviews] review granted: [Bug 200954] REGRESSION (r248807): Objects stored in ElementRareData are leaked : [Attachment 377181] Fixes the bug

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 200954: REGRESSION (r248807): Objects stored in ElementRareData are leaked
https://bugs.webkit.org/show_bug.cgi?id=200954

Attachment 377181: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=377181&action=review




--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 377181
  --> https://bugs.webkit.org/attachment.cgi?id=377181
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=377181&action=review

r=me

> Source/WebCore/dom/NodeRareData.h:277
> +    virtual ~NodeRareData()
> +    { }

Do we need to declare this inline?  I recall saving space by not inlining
destructors of some classes.  (I guess this is rare, though? :)