[webkit-reviews] review granted: [Bug 201085] [iOS] [WebKit2] Tapping on the “I’m” text suggestion after typing “i’” does nothing : [Attachment 377151] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 201085: [iOS] [WebKit2] Tapping on the “I’m” text suggestion after typing
“i’” does nothing
https://bugs.webkit.org/show_bug.cgi?id=201085

Attachment 377151: Patch

https://bugs.webkit.org/attachment.cgi?id=377151&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 377151
  --> https://bugs.webkit.org/attachment.cgi?id=377151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377151&action=review

> Source/WebCore/editing/TextIterator.h:57
> +WEBCORE_EXPORT String foldQuoteMarks(String);

Seems a little peculiar to have the argument the be "String" rather than "const
String&". Also, I am a little concerned using this outside the context of ICU’s
usearch. The folding here was specifically to work around what usearch does and
does not do. This folding alone without all the other folding that usearch does
is a sort of peculiar subset. Finally, it’s not great to have this in this
header since it’s not really an "iteration" thing. Just because the file-local
version was here doesn’t mean this is a good logical home for the function.