[webkit-reviews] review granted: [Bug 201040] Make MediaStreamTrackPrivate RefCounted : [Attachment 377013] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 201040: Make MediaStreamTrackPrivate RefCounted
https://bugs.webkit.org/show_bug.cgi?id=201040

Attachment 377013: Patch

https://bugs.webkit.org/attachment.cgi?id=377013&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 377013
  --> https://bugs.webkit.org/attachment.cgi?id=377013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377013&action=review

I’m going to say review+, but I am just taking your word for it that this is
correct.

> Source/WebCore/ChangeLog:3
> +	   Make MediaStreamTrackPrivate RefCounted

Really need a "why" comment in the change log.

I think it’s "MediaStreamTrackPrivate does not need to be ThreadSafeRefCounted
because all use of these objects including ref/deref is on the main thread."