[webkit-reviews] review granted: [Bug 198923] Support ITP on a per-session basis : [Attachment 377129] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 23 10:19:21 PDT 2019


Chris Dumez <cdumez at apple.com> has granted Katherine_cheney at apple.com's request
for review:
Bug 198923: Support ITP on a per-session basis
https://bugs.webkit.org/show_bug.cgi?id=198923

Attachment 377129: Patch

https://bugs.webkit.org/attachment.cgi?id=377129&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 377129
  --> https://bugs.webkit.org/attachment.cgi?id=377129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377129&action=review

r=me with fix.

> Source/WebCore/loader/ResourceLoadObserver.cpp:403
> +	   iter.value->clear();

Rather than doing this, I would do m_perSessionResourceStatisticsMap.clear()
*after* the loop. No reason to keep the sessionIDs in the map.


More information about the webkit-reviews mailing list