[webkit-reviews] review granted: [Bug 200972] [GStreamer] Hole-punch build is broken : [Attachment 376859] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 23 03:38:11 PDT 2019
Zan Dobersek <zan at falconsigh.net> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 200972: [GStreamer] Hole-punch build is broken
https://bugs.webkit.org/show_bug.cgi?id=200972
Attachment 376859: Patch
https://bugs.webkit.org/attachment.cgi?id=376859&action=review
--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 376859
--> https://bugs.webkit.org/attachment.cgi?id=376859
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376859&action=review
> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:72
> virtual void setVideoRectangle(const IntRect&) = 0;
> - virtual ~HolePunchClient() = 0;
> + virtual ~HolePunchClient() = default;
Nit: the destructor should be placed first.
More information about the webkit-reviews
mailing list