[webkit-reviews] review granted: [Bug 201036] Remove MaximalFlushInsertionPhase : [Attachment 377078] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 201036: Remove MaximalFlushInsertionPhase
https://bugs.webkit.org/show_bug.cgi?id=201036

Attachment 377078: Patch

https://bugs.webkit.org/attachment.cgi?id=377078&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 377078
  --> https://bugs.webkit.org/attachment.cgi?id=377078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377078&action=review

r=me

Please also add the new test from Radar

> Source/JavaScriptCore/ChangeLog:9
> +	   to remove it instead of hacking it to fix the most recent false
positive.

It would be good to describe the latest issue to motivate why it’s not worth
keeping

>
JSTests/stress/set-argument-maybe-maximal-flush-should-not-extend-liveness-2.js
:-1
> -//@ runDefault("--useMaximalFlushInsertionPhase=1", "--jitPolicyScale=0",
"--useConcurrentJIT=0")

Let’s keep these tests and just remove the option