[webkit-reviews] review granted: [Bug 201061] Undo disabling of IsoHeaps when Gigacage is off. : [Attachment 377086] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 21:57:26 PDT 2019


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 201061: Undo disabling of IsoHeaps when Gigacage is off.
https://bugs.webkit.org/show_bug.cgi?id=201061

Attachment 377086: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=377086&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 377086
  --> https://bugs.webkit.org/attachment.cgi?id=377086
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=377086&action=review

> Source/bmalloc/bmalloc/PerThread.h:2
> + * Copyright (C) 2014-2017 Apple Inc. All rights reserved.

Is this intentional? Did you mean 2019?

> Source/bmalloc/bmalloc/ProcessCheck.mm:-47
> -	   || [processName isEqualToString:@"DumpRenderTree"]

Why?


More information about the webkit-reviews mailing list