[webkit-reviews] review granted: [Bug 197172] JSC should have public API for unhandled promise rejections : [Attachment 376949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 17:04:10 PDT 2019


Keith Miller <keith_miller at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 197172: JSC should have public API for unhandled promise rejections
https://bugs.webkit.org/show_bug.cgi?id=197172

Attachment 376949: Patch

https://bugs.webkit.org/attachment.cgi?id=376949&action=review




--- Comment #48 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 376949
  --> https://bugs.webkit.org/attachment.cgi?id=376949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376949&action=review

r=me.

> Source/JavaScriptCore/API/tests/testapi.cpp:521
>  }

Can you add tests for:

1) promise that's rejected then handled synchronously.
2) promise that's rejected then handled in a microtask turn.
3) promise that's rejected in a microtask then handled in a later microtask.
4) promise that's rejected in a microtask then not handled.

> Source/JavaScriptCore/runtime/VM.h:1072
> +    Vector<Strong<JSPromise>> m_aboutToBeNotifiedRejectedPromises;

Can you add a FIXME with a link to the bug you filed?


More information about the webkit-reviews mailing list