[webkit-reviews] review granted: [Bug 201025] results.webkit.org: Escape html in changelog : [Attachment 377028] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 16:57:27 PDT 2019

Darin Adler <darin at apple.com> has granted Jonathan Bedard <jbedard at apple.com>'s
request for review:
Bug 201025: results.webkit.org: Escape html in changelog

Attachment 377028: Patch


--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 377028
  --> https://bugs.webkit.org/attachment.cgi?id=377028

View in context: https://bugs.webkit.org/attachment.cgi?id=377028&action=review

While I’m not an expert at this, I’ll review since I spotted a bug earlier.

> Tools/resultsdbpy/resultsdbpy/view/templates/commit.html:64
> +		   return '';

Maybe this should return match instead of ''.

More information about the webkit-reviews mailing list