[webkit-reviews] review granted: [Bug 201049] [Subpixel layout] reddit.com comments are slightly scrollable : [Attachment 377038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 13:38:11 PDT 2019

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 201049: [Subpixel layout] reddit.com comments are slightly scrollable

Attachment 377038: Patch


--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 377038
  --> https://bugs.webkit.org/attachment.cgi?id=377038

View in context: https://bugs.webkit.org/attachment.cgi?id=377038&action=review

> Source/WebCore/ChangeLog:9
> +	   Since RootLines are forced to be on integral positions, we need to
ensure that the block container's height is adjusted accordingly (to always
enclose the lines in the case of LayoutUnit -> int conversion).  

Need more explanation here.

More information about the webkit-reviews mailing list