[webkit-reviews] review granted: [Bug 200952] [WASM-References] Do not overwrite argument registers in jsCallEntrypoint : [Attachment 377031] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 13:18:36 PDT 2019


Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 200952: [WASM-References] Do not overwrite argument registers in
jsCallEntrypoint
https://bugs.webkit.org/show_bug.cgi?id=200952

Attachment 377031: Patch

https://bugs.webkit.org/attachment.cgi?id=377031&action=review




--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 377031
  --> https://bugs.webkit.org/attachment.cgi?id=377031
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377031&action=review

r=me

> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:321
> +		   jit.loadPtr(vm.addressOfSoftStackLimit(), stackLimitGPR);

please remove.


More information about the webkit-reviews mailing list