[webkit-reviews] review denied: [Bug 200945] Add default to disable legacy TLS versions : [Attachment 376952] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 10:06:36 PDT 2019


Brady Eidson <beidson at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 200945: Add default to disable legacy TLS versions
https://bugs.webkit.org/show_bug.cgi?id=200945

Attachment 376952: Patch

https://bugs.webkit.org/attachment.cgi?id=376952&action=review




--- Comment #12 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 376952
  --> https://bugs.webkit.org/attachment.cgi?id=376952
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376952&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:284
> +   
parameters.defaultDataStoreParameters.networkSessionParameters.enableLegacyTLS
= [defaults boolForKey:@"WebKitEnableLegacyTLS"];

Oof

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:72
> +    bool enableLegacyTLS = [defaults boolForKey:@"WebKitDisableLegacyTLS"];

Oof.


More information about the webkit-reviews mailing list