[webkit-reviews] review granted: [Bug 201000] run-webkit-tests: Use -noBulkSymbolication when calling spindump : [Attachment 376948] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 201000: run-webkit-tests: Use -noBulkSymbolication when calling spindump
https://bugs.webkit.org/show_bug.cgi?id=201000

Attachment 376948: Patch

https://bugs.webkit.org/attachment.cgi?id=376948&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 376948
  --> https://bugs.webkit.org/attachment.cgi?id=376948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376948&action=review

> Tools/Scripts/webkitpy/port/darwin.py:181
> +		   exit_code = host.executive.run_command(spindump_command +
['-noBulkSymbolication'], return_exit_code=True)

It looks like the fallback won't be needed once macOS Catalina is the oldest
supported version. Please add a comment explaining what's happening here in
some reasonable detail (at least a radar link, and a FIXME to remove).

That said, I'm not entirely sure which platforms we try to run this on. This is
darwin.py, does that mean that this code runs on iOS?